Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for exact number of calls #82

Merged
merged 4 commits into from Jan 13, 2018
Merged

Support for exact number of calls #82

merged 4 commits into from Jan 13, 2018

Conversation

ldemailly
Copy link
Member

Fixes #75
If you set RunnerOptions.Exactly to any number that exact number of
calls will be made, and without additional warmup - it will still try
to reach the target QPS but if the service is slower it will take the
time it will take

On the command line this mode is selected using “-n num”
(The replaces/extends the grpc ping count flag)

Fixes #75
If you set RunnerOptions.Exactly to any number that exact number of
calls will be made, and without additional warmup - it will still try
to reach the target QPS but if the service is slower it will take the
time it will take

On the command line this mode is selected using “-n num”
(The replaces/extends the grpc ping count flag)
@codecov
Copy link

codecov bot commented Jan 13, 2018

Codecov Report

Merging #82 into master will increase coverage by 0.8%.
The diff coverage is 91.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #82     +/-   ##
========================================
+ Coverage    82.2%   82.9%   +0.8%     
========================================
  Files           6       6             
  Lines        1311    1313      +2     
========================================
+ Hits         1077    1089     +12     
+ Misses        164     155      -9     
+ Partials       70      69      -1
Impacted Files Coverage Δ
periodic/periodic.go 97.4% <100%> (+0.3%) ⬆️
fgrpc/grpcrunner.go 75.8% <33.3%> (+5.6%) ⬆️
fhttp/httprunner.go 80.6% <66.7%> (+0.3%) ⬆️
fhttp/http.go 69.8% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488e250...2c825f4. Read the comment docs.

Set the requested duration to be the expected number of calls
@ldemailly
Copy link
Member Author

@mandarjog this could help tracking down the rate limit and metrics issues:
if you ask it to do N requests it will do exactly N whatever the time it takes and without extra warmup calls

@ldemailly ldemailly mentioned this pull request Jan 13, 2018
14 tasks
@ldemailly ldemailly merged commit 19635c4 into master Jan 13, 2018
@ldemailly ldemailly deleted the exact-count branch January 13, 2018 05:55
@mandarjog
Copy link
Collaborator

@ldemailly used it right away with -n 100, thanks.

@ldemailly
Copy link
Member Author

ldemailly commented Jan 13, 2018

@ldemailly used it right away with -n 100, thanks.

@mandarjog cool! I'm glad ! you can also use the ui if you run fortio server either inside or outside your cluster

screen shot 2018-01-12 at 11 19 22 pm

And once istio/istio#2596 goes in, from test code, using

Exactly: 100, 

or o.Exactly = 100 in the (HTTP)RunnerOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants