Update fortio version to latest #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not clear why Gopkg.lock changed so much
istio-merge-robot
added
the
needs-rebase
|
@ldemailly PR needs rebase |
# Conflicts: # Gopkg.lock
ldemailly
removed
the
needs-rebase
costinm
reviewed
Jan 13, 2018
istio.VERSION
Outdated
| @@ -13,6 +13,6 @@ export AUTH_DEBIAN_URL="https://storage.googleapis.com/istio-artifacts/auth/d10e | |||
| export PILOT_DEBIAN_URL="https://storage.googleapis.com/istio-artifacts/pilot/3101ea9d82a5f83b699c2d3245b371a19fa6bef4/artifacts/debs" | |||
| export PROXY_DEBIAN_URL="https://storage.googleapis.com/istio-artifacts/proxy/2458e4e27bc588df858711b66de0970183e0cf66/artifacts/debs" | |||
| export FORTIO_HUB="docker.io/istio" | |||
| export FORTIO_TAG="0.4.2" | |||
| export FORTIO_TAG="0.6.1" | |||
There was a problem hiding this comment.
Do we still need this, and for what ?
(this goes for the entire file)
There was a problem hiding this comment.
it's used in e2e still afaik, for instance:
tests/e2e/tests/simple/simple1_test.go: tag := os.Getenv("FORTIO_TAG")
and in updateVersion
# Conflicts: # Gopkg.lock
Tried ``` dep ensure --update istio.io/fortio Warning: Gopkg.lock is out of sync with Gopkg.toml or the project's imports. ``` But it did change everything in the lock file anyway
istio-merge-robot
added
the
needs-rebase
|
@ldemailly PR needs rebase |
istio-merge-robot
removed
the
needs-rebase
douglas-reid
approved these changes
Jan 16, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test istio-presubmit |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not clear why Gopkg.lock changed so much