Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Channel not found log to warning #12

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Fix: Channel not found log to warning #12

merged 2 commits into from
Oct 22, 2023

Conversation

ani1311
Copy link
Collaborator

@ani1311 ani1311 commented Oct 22, 2023

Closes #6

@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
app.go 24.40% <0.00%> (ø)
server.go 55.67% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@ani1311
Copy link
Collaborator Author

ani1311 commented Oct 22, 2023

Had a small NIT. Was thinking of moving line 98 to 218.

Just to the adding to doNotProcessChannels outside CheckError. Wanted to check if thats ok?

@wiardvanrij
Copy link
Collaborator

Had a small NIT. Was thinking of moving line 98 to 218.

Just to the adding to doNotProcessChannels outside CheckError. Wanted to check if thats ok?

I'm not getting it, but perhaps just make the change and we can review it (and/or just make a new MR for it so we can merge this one in for sure)

ldemailly
ldemailly approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, are there any more cases that are in between info and error?

@ani1311
Copy link
Collaborator Author

ani1311 commented Oct 22, 2023 •
edited

Maybe this could be warning or error: https://github.com/fortio/slack-proxy/blob/main/server.go#L60
Queue is almost full.

@wiardvanrij wiardvanrij marked this pull request as ready for review October 22, 2023 19:26
@wiardvanrij wiardvanrij merged commit da87622 into main Oct 22, 2023
5 of 6 checks passed
@wiardvanrij wiardvanrij deleted the fix-channel-not-found-log-to-warn branch October 22, 2023 19:27
@ani1311 ani1311 mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldemailly ldemailly ldemailly approved these changes

@wiardvanrij wiardvanrij wiardvanrij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use warning level for "Channel not found, pausing for 15 minutes"
3 participants
@ani1311 @wiardvanrij @ldemailly