Cleanup: Small nit on doNotProcessChannels #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small NIT about what I was saying here: #12 (comment)
Can revert if this doesn't make sense, made the MR because it's easier to explain the change with MR than in comments.
But the reasoning was,
CheckError
felt a bit more of a no state change function. So wanted to move thedoNotProcessChannels
addition at caller.