Use grunt-sass and libsass #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also data-ft-* attrs, in case you are making valid xHTML Pro XML Enterprise Verified pages kudos to @wnadeau
blocks are now components trumps are now utilties more user friendly...
Also updated a few settings to follow convetions of feature flags
Feature/easy optin denamespace
Use ft-* attrs rather than class names for js
Fix attr- and data-attr support
Cool new feature: tabs-navigation can be used without specifying ids (if you're brave)
Update the js components so they match the docs
previous events were open,opened,close,closed new events are show,shown,hide,hidden
Feature/rails conf aaron
Also start DRYing up horrible specs
Fix navbar and modal components
Copy and formatting pass on documentation
Update navigationbar to use thought process for show/hide states
Fix styles in navigationbar
Feature/rails conf
|
@agius looks like the build is failing but if you can get all the things to pass I'll take a look 👍 |
|
Bootcamp does not appear to be compatible with Libsass and since that issue has been open since June 2014, it doesn't seem to be a priority for them. Not sure what to do without that - maybe Wraith? Could test css output with quixote |
|
@agius I'm ok with not using bootcamp. But we should definitely find something to test the CSS output. |
|
Can you pair sometime soon on this? Maybe we can figure out what the higher priorities are on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weird -
grunt buildworks, andgrunt sass:distwork. And boy is it fast! Seems like only Bootcamp is not compatible. Did they add map functionality to libsass?Anyone get some 👀 on this and see if the output is missing a bunch of stuff or something? Looks like it has the responsive helpers, which was the thing I was sure would explode.