Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dissect.esedb compatibility to secretsdump #1452

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Schamper
Copy link

@Schamper Schamper commented Dec 20, 2022

See #1448. I'm not sure how tightly integrated you'd want this to be in impacket, so I opted for a simple compatibility shim. This can of course be changed to a full replacement of the existing ESE implementation.

This should bring a considerable performance improvement to secretsdump. My sample AD with only 3 users already sees an improvement (1s vs 2s), but in the past we've seen domains with over 100k users take less than a minute, whereas the original secretsdump would take >24 hours.

@dirkjanm

https://github.com/fox-it/dissect.esedb

@gabrielg5 gabrielg5 added the in review This issue or pull request is being analyzed label Feb 9, 2023
@anadrianmanrique anadrianmanrique added low Low priority item and removed in review This issue or pull request is being analyzed labels Feb 16, 2023
@anadrianmanrique anadrianmanrique added the on hold Awaiting an action or decision to move forward label Mar 2, 2023
@Paradoxis
Copy link

Is there any plans of adding this in the near future? Secretsdump is painfully slow in large scale environments and this would be a real improvement

@almandin
Copy link
Contributor

Can confirm that using esedb from dissect can handle very large NTDS, I parse multi-GB NTDS files with ntdsdotsqlite. Last time I checked I parsed a 7GB NTDS file in like 6/7 minutes (even though it extracts everything : groups, users, computers, domains, orga. units etc...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low Low priority item on hold Awaiting an action or decision to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants