Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent regeneration of project.yaml files in production #157

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Prevent regeneration of project.yaml files in production #157

merged 2 commits into from
Feb 6, 2023

Conversation

ostark
Copy link
Collaborator

@ostark ostark commented Jan 27, 2023

This should avoid conflicts with Project Config.
Working theory: If there is no "external project config" Craft can not detect (and warn about) any changes.

@ostark ostark requested a review from pheeque1 January 27, 2023 11:37
pheeque1
pheeque1 requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@pheeque1 pheeque1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this totally resolves the problem. There's still a prompt to apply changes in the admin dashboard of the app I tested.

@ostark
Copy link
Collaborator Author

ostark commented Feb 4, 2023

Better now? @pheeque1

@ostark
Copy link
Collaborator Author

ostark commented Feb 6, 2023

I tested it eventually, LGTM.

@ostark ostark merged commit a0fafe1 into master Feb 6, 2023
@ostark ostark deleted the fix/disable-writeYamlAutomatically branch February 6, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheeque1 pheeque1 pheeque1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ostark @pheeque1