Revert mysql client issues workaround #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinbit
force-pushed
the
fix/revert-mysql-workaround
branch
from
7bd8739
to
9392709
Compare
pheeque1
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Are these changes related and absolutely necessary in this PR? If so, they should probably be noted in the Changelog as well.
There was a problem hiding this comment.
True not strictly related, but this file is only used in the automated tests, and I wanted to get rid of the warnings shown there now, cause I probably won't look at this repo for a while :)
|
Thanks for the review ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an ongoing issue on our platform with mysql-client and mysqldump version 5.7.41. We have now reverted to 5.7.40 and this workaround is no longer needed.
The workaround itself was also causing issues for some clients with mysqldump saying option
--ssl-modedoes not exist. This resolves those issues as well.