Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_proc_parent is ignored #630

Closed
mscfd opened this issue Feb 28, 2024 · 2 comments · Fixed by #641
Closed

show_proc_parent is ignored #630

mscfd opened this issue Feb 28, 2024 · 2 comments · Fixed by #641

Comments

@mscfd
Copy link

mscfd commented Feb 28, 2024

It looks like that show_proc_parent is not used anywhere. I assume that it was meant to control the prefix in procedure nodes, done in ProcNode.init:

        parent_label = ""
        binding_label = ""
        if parent:
            parent_label = f"{parent.name}::"
        if binder:
            binding_label = f"{binder.name}%"

        self.attribs["label"] = f"{parent_label}{binding_label}{self.name}"

Indeed, it looks like that show_proc_parent accidentially got lost in commit 859ef3e?

@ZedThree
Copy link
Member

I think it was decided it was more sensible to have this be always on, but it looks like it wasn't removed completely.

@mscfd
Copy link
Author

mscfd commented Feb 28, 2024

I looked into this option because the procedure call-graphs where stretched far too much because of node labels. Because of the global namespace in fortran, it is typical in f90/95 code to prefix subroutines and functions by something related to the module name, which itself needs to be rather descriptive due to the global namespace. For example:

solver_bicgstab_aux_mod.f90 contains a subroutine solver_bicgstab_setup_vectors

yields a big node with text

solver_bicgstab_aux_mod::solver_bicgstab_setup_vectors

which is not really readable, as the routine already contains almost all the info.

Anyway, I can easily keep this option by local patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants