Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added ability to post ratings to the package #79

Merged
merged 1 commit into from
May 25, 2024

Conversation

arteevraina
Copy link
Member

Description

  • Added functionality to rate packages from the frontend.

Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arteevraina, I have suggested some minor changes.

url: `${process.env.REACT_APP_REGISTRY_API_URL}/ratings/${namespaceName}/${packageName}`,
data: formData,
headers: {
Authorization: `Bearer ${access_token}`,
Copy link
Member

@henilp105 henilp105 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should verify if access_token is undefined and only allow if the user is loggedIn.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patched in #80

henilp105 added a commit to henilp105/registry that referenced this pull request Apr 18, 2024
henilp105 added a commit to henilp105/registry that referenced this pull request Apr 18, 2024
@henilp105 henilp105 merged commit 5a095f3 into fortran-lang:main May 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants