Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button text translated removes all the button properties #29

Closed
henilp105 opened this issue Aug 10, 2022 · 3 comments · Fixed by #35
Closed

button text translated removes all the button properties #29

henilp105 opened this issue Aug 10, 2022 · 3 comments · Fixed by #35
Labels
bug Something isn't working i18n Localisation and internationalisation of the webpage

Comments

@henilp105
Copy link
Member

henilp105 commented Aug 10, 2022 •
edited
Loading

@awvwgk Sir, as we add translation for text in buttons they lose their properties on the translated page. Most likely seems to be a bug of myst/sphinx. Example can be found on index page of de translation ("Get Started" button on index page). I have also been abel to reproduce this is various other buttons of like learn section in all the translations. How should we be able to resolve them ?

Thanks and Regards,
Henil Shalin Panchal

CC @awvwgk
@awvwgk
Copy link
Member

awvwgk commented Aug 10, 2022

I think executablebooks/sphinx-design#44 is still an issue with sphinx-design. Didn't really get any input from upstream on this so far.

@awvwgk
Copy link
Member

awvwgk commented Aug 10, 2022

For the fpm docs we don't add translations to buttons for this reason, which is suboptimal. In the TOML Fortran documentation I avoided using buttons for this reason and just made the whole card clickable.

@awvwgk awvwgk added bug Something isn't working i18n Localisation and internationalisation of the webpage labels Aug 10, 2022
@awvwgk
Copy link
Member

awvwgk commented Aug 10, 2022

Alternative discussed today might be to create the button using :::{div} directive and manually add the classes.

This was referenced Aug 11, 2022
Closed
Merged
awvwgk pushed a commit that referenced this issue Aug 12, 2022
@henilp105
Google Summer of Code’22: Port fortran-lang.org to Sphinx (#35)
14c675e 
- added pr preview banner for preview builds. (independent of the pydata theme version)
- added documentation for pre-commit hooks
- locked the dependency versions of packages
- formatted the html templates
- resolved the date error in newsletter of june 2022
- enabled build of all translations for build preview
- resolved button text translated removes all the button properties #29 (for index page)
- added dependabot for requirements.txt
- updated translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working i18n Localisation and internationalisation of the webpage
Projects
None yet
Milestone
No milestone
2 participants
@awvwgk @henilp105