Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Lua Collections to use Lua tables instead of std::vector #91

Closed
squeek502 opened this issue Dec 9, 2014 · 0 comments · Fixed by #136
Closed

Convert Lua Collections to use Lua tables instead of std::vector #91

squeek502 opened this issue Dec 9, 2014 · 0 comments · Fixed by #136
Assignees
@squeek502
Labels
lua

Comments

@squeek502
Copy link
Member

The std::vector implementation is unnecessary and seems to have some issues (seen it cause a few hard-to-debug crashes related to iterators while destructing at Shutdown).

See: https://github.com/fortressforever/fortressforever/blob/beta/dlls/ff/ff_lualib_util.cpp
@squeek502 squeek502 self-assigned this Dec 9, 2014
This was referenced Mar 18, 2015
Open
Merged
squeek502 added a commit to fortressforever/fortressforever-scripts that referenced this issue Mar 23, 2015
@squeek502
Start of Lua-based collection implementation
55237d4 
 * Will eventually replace the entire Collection userdata with full backwards compatibility
 * See fortressforever/fortressforever#91
@squeek502 squeek502 mentioned this issue Mar 23, 2015
Merged
squeek502 added a commit that referenced this issue Mar 24, 2015
@squeek502
Lua: Remove the C++ Collection implementation
7a6b42e 
 * Closes #91
@squeek502 squeek502 mentioned this issue Mar 24, 2015
Merged
squeek502 added a commit to fortressforever/fortressforever-scripts that referenced this issue Mar 27, 2015
@squeek502
Start of Lua-based collection implementation
171376e 
 * Will eventually replace the entire Collection userdata with full backwards compatibility
 * See fortressforever/fortressforever#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squeek502 squeek502

Labels
lua
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the C++ Collection implementation fortressforever/fortressforever
1 participant
@squeek502