Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update func_button:ondamage lua callback to use parameters instead of global vars #214

Merged
merged 1 commit into from Apr 30, 2015
Merged

Update func_button:ondamage lua callback to use parameters instead of global vars #214

merged 1 commit into from Apr 30, 2015

Conversation

squeek502
Copy link
Member

  • The damageinfo is now passed as a parameter to func_button:ondamage
  • This is a breaking change in that it's not backwards compatible, but I think it's a safe bet that no one was using the completely hidden global variables that get defined when ondamage() gets called
  • This also removes the 'return false to stop the damage' thing, which is unnecessary and confusing

@squeek502
Update func_button:ondamage lua callback to use parameters instead of…
8cda92b 
… global vars

 * This is a breaking change in that it's not backwards compatible, but I think it's a safe bet that no one was using the completely hidden global variables that get defined when ondamage() gets called
 * This also removes the 'return false to stop the damage' thing, which is unnecessary and confusing
squeek502 added a commit that referenced this pull request Apr 30, 2015
@squeek502
Merge pull request #214 from fortressforever/lua/button-ondamage
e5f7b9b 
Update func_button:ondamage lua callback to use parameters instead of global vars
@squeek502 squeek502 merged commit e5f7b9b into beta Apr 30, 2015
@squeek502 squeek502 deleted the lua/button-ondamage branch August 7, 2015 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lua
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@squeek502