Fix silent grenades when client doesn't think you can prime yet #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it was possible to prime a grenade but not get any timers on the client, since the command would be sent to the server even though the client thinks the command is impossible. Example: If you immediately try to prime a gren as you spawn and your latency is high enough, then the client will think you're still dead and not start the timers, but by the time the command gets to the server it will think you're alive and prime it anyway This fixes it so that if the client thinks you can't run a command, then the command is not sent to the server. Also updated all the shared commands with this fix so this might have some side-benefits to other things like cloaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it was possible to prime a grenade but not get any timers on the client, since the command would be sent to the server even though the client thinks the command is impossible. Example: If you immediately try to prime a gren as you spawn and your latency is high enough, then the client will think you're still dead and not start the timers, but by the time the command gets to the server it will think you're alive and prime it anyway
This fixes it so that if the client thinks you can't run a command, then the command is not sent to the server. Also updated all the shared commands with this fix so this might have some side-benefits to other things like cloaking.