Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the way the spies name is displayed when disguised #373

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

alaswell
Copy link
Member

@alaswell alaswell commented Sep 1, 2019

This is completely untested, but should resolve #368

Copy link
Member

@squeek502 squeek502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note: this is only part of #368--the other part would be syncing the chosen player across all clients so that each person sees the same name, which would also allow us to show the spy which person they are disguised as.

Right now the name is/will be different between each client, but syncing it would require changes to the networking tables, which would cause a 'server uses different class tables' error and force servers to update which isn't ideal since servers can be pretty slow to update these days.

@alaswell
Copy link
Member Author

alaswell commented Sep 2, 2019

Yes, good point on the other part of #368

We will have to add that in if/when the networking tables change again for something more significant.

@doublah
Copy link

doublah commented Sep 9, 2019

How does this look from spectator? Is it changed there?

@squeek502
Copy link
Member

squeek502 commented Sep 9, 2019

Do you know if crosshairinfo shows while spectacting? I would think this stops it from showing:

if( !pPlayer->IsAlive() )
Reset();

@alaswell alaswell merged commit dac3588 into beta Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spy disguise name choice
3 participants