Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the way the spies name is displayed when disguised #373

Open
wants to merge 1 commit into
base: beta
from

Conversation

@alaswell
Copy link
Member

commented Sep 1, 2019

This is completely untested, but should resolve #368

@squeek502
Copy link
Member

left a comment

Looks good.

Note: this is only part of #368--the other part would be syncing the chosen player across all clients so that each person sees the same name, which would also allow us to show the spy which person they are disguised as.

Right now the name is/will be different between each client, but syncing it would require changes to the networking tables, which would cause a 'server uses different class tables' error and force servers to update which isn't ideal since servers can be pretty slow to update these days.

@alaswell

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

Yes, good point on the other part of #368

We will have to add that in if/when the networking tables change again for something more significant.

@doublah

This comment has been minimized.

Copy link

commented Sep 9, 2019

How does this look from spectator? Is it changed there?

@squeek502

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Do you know if crosshairinfo shows while spectacting? I would think this stops it from showing:

if( !pPlayer->IsAlive() )
Reset();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.