Adding http POST method support to healthcheck #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, I'll look at merging this ASAP. |
| :result => '{ json_response: as_string }' | ||
| :https => true, | ||
| :timeout => 10, | ||
| :http_method => :post, |
There was a problem hiding this comment.
:via might be an easier option name, default being :via => :get, great feature to add btw.
There was a problem hiding this comment.
Nice, i'll change!
|
Just curious, what API services require a POST request? xmlrpc based API? |
|
I have one service with one api for processing data and for health check i need a POST method. |
Rylon
added a commit
that referenced
this pull request
Aug 26, 2014
Adding http POST method support to healthcheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding http POST method support to healthcheck, because some api services need check if service is ok by request a post with json data.