Revert "Add Mac arm64 executable (#1426)" #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75363fc.
JeffreyHuynh1
approved these changes
May 10, 2024
csasarak
added a commit
that referenced
this pull request
May 13, 2024
csasarak
added a commit
that referenced
this pull request
May 28, 2024
* Reapply "Add Mac arm64 executable (#1426)" (#1429) This reverts commit 36e62bb. * Zip up the right archive. * Try adding an entitlement. * Explicitly install xz. * try entitlements. * Move entitlements arg. * Fix condition * wip * Only use entitlements for arm64. * Use correct equality. * Restore full conditional. * Fix conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 75363fc.
Overview
During the initial go of implementing this I missed some issues with codesigning and notarization on Mac that need to be resolved. This PR reverts the mac arm release so that it doesn't get in the way of any other releases.