refactor (gradle analysis) add a test suite and clean up code. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 42.98% 45.84% +2.85%
==========================================
Files 81 81
Lines 4234 4234
==========================================
+ Hits 1820 1941 +121
+ Misses 2243 2110 -133
- Partials 171 183 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 42.98% 45.84% +2.85%
==========================================
Files 81 81
Lines 4234 4234
==========================================
+ Hits 1820 1941 +121
+ Misses 2243 2110 -133
- Partials 171 183 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle analysis has been growing by small PR's for a while and needed to be refactored in order to create a robust testing method. This PR introduced testing for
analyzer/gradleDiscovery and Analysis, and manybuildtool/gradlefunctions.This PR also includes a fair amount of renaming within
buildtools/gradlein order to clarify what the functions are doing and ensure that production vs testing paths are more explicit.This PR fixes the gradle test flake on circle ci.