Improve Makefile, add multiple targets #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
force-pushed
the
improve_makefile
branch
from
c029f8d
to
7e25da7
Compare
Adds targets to do things like: * build * install * vendor Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
seemethere
force-pushed
the
improve_makefile
branch
from
7e25da7
to
821d6e8
Compare
|
Gotcha. Saw |
|
We've got a CLA set up using SAP's CLA assistant (see "details" link in the PR merge check or direct link here). Our CLA is modelled after the ASF's, so everything in it should be pretty standard. The intent here is to allow us to potentially relicense down the road without needing to chase down all contributors. Happy to merge this and #99 in as soon as you sign! |
meghfossa
pushed a commit
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to do a
make buildon the project and found that it didn't work.Adds targets to do things like:
There'll be a follow up PR to do the vendoring as well so that you can actually build from the source directory instead of having to install all the dependencies into your
$GOPATH/src/ping @ilikebits
Signed-off-by: Eli Uriegas eli.uriegas@docker.com