Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce vendor directory into the repo #99

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

seemethere
Copy link
Contributor

@seemethere seemethere commented Mar 9, 2018

Was trying to build the CLI from the source directory and I could not,
this re-adds the vendor directory so we can build the CLI from the
source repository instead of having to dep ensure everytime

ping @ilikebits

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere
Copy link
Contributor Author

Not really seeing why the tests are failing?

Was trying to build the CLI from the source directory and I could not,
this re-adds the vendor directory so we can build the CLI from the
source repository instead of having to `dep ensure` everytime

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@elldritch
Copy link
Member

elldritch commented Mar 12, 2018

The tests are failing because our tests have a dependency on the FOSSA API, which requires us to pass a secret API key to the tests. This is not passed to tests running on forked PR branches for security reasons. We should probably turn off the API tests for non-master commits.

I'm not sure that committing vendor is a best practice, and installing with go get -u github.com/fossas/fossa-cli/cmd/fossa works for me. What are the steps for reproducing your installation failure, and what are the arguments for checking in vendor? (The main argument I can think of against committing vendor is repository size.)

@seemethere
Copy link
Contributor Author

seemethere commented Mar 12, 2018

@ilikebits Committing a vendor is standard practice for almost every golang project on Github.

See:

What it allows you to do is not pollute your $GOPATH/src/ with dependencies from a go get -u

Even your CircleCI builds don't do a go get they do a dep ensure before running make. https://github.com/fossas/fossa-cli/blob/master/.circleci/config.yml#L25-L26

@elldritch elldritch merged commit 44fb451 into fossas:master Mar 12, 2018
meghfossa pushed a commit that referenced this pull request Nov 12, 2021
* Upload IPR scan results in chunks of 1 MB, and post to the "IPR scan complete" endpoint once all IPR results have been posted.
* Upload build graph results in chunks of 1 MB instead of in groups of 10 targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants