Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Releases/installation.md #26

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Update Releases/installation.md #26

merged 1 commit into from
Feb 24, 2019

Conversation

akshat157
Copy link
Contributor

@akshat157 akshat157 commented Oct 1, 2018

Current guide contains a non-existent path to manifest.json.
This commit updates it with the correct installation path for Firefox.

Also, here's an instructional image to replace the previous one:
instructions

- Current guide contains a non-existent path to manifest.json.
  This commit updates it with the correct installation path for Firefox.
Copy link
Member

@0x48piraj 0x48piraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this image to the README.md

@akshat157
Copy link
Contributor Author

I'm adding it to README.md's installation section, sounds good?

@0x48piraj
Copy link
Member

Don't remove mine, it's for chrome. you've done for Firefox.

@akshat157
Copy link
Contributor Author

Okay. Apologies. Will revert! 😅
But should I add this one to Releases/installation.md as a separate one or README.md, in the installation section?

@0x48piraj
Copy link
Member

The latter

@akshat157
Copy link
Contributor Author

The requested addition was done in #28
Apologies for the little mess with this one though. 🙂

@akshat157 akshat157 mentioned this pull request Oct 1, 2018
@akshat157
Copy link
Contributor Author

@0x48piraj any updates on this?

@0x48piraj 0x48piraj merged commit fef67da into fossasia:master Feb 24, 2019
@akshat157 akshat157 deleted the update-installation-md branch February 24, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants