Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multilanguage support #377

Merged
merged 1 commit into from
Jun 15, 2019
Merged

feat: multilanguage support #377

merged 1 commit into from
Jun 15, 2019

Conversation

adityastic
Copy link
Collaborator

@adityastic adityastic commented Jun 13, 2019 •
edited
Loading

Fixes #366

Changes:

  • Added Language Support for:
    • Chinese

Screenshots for the change:

3662

@auto-label auto-label bot added the feature label Jun 13, 2019
@adityastic adityastic changed the title feat: multilanguage support WIP feat: multilanguage support Jun 13, 2019
@auto-label auto-label bot removed the feature label Jun 13, 2019
@adityastic adityastic force-pushed the patch-366 branch 2 times, most recently from 5a3dc2f to a2084ae Compare June 13, 2019 10:05
@adityastic adityastic changed the title WIP feat: multilanguage support feat: multilanguage support Jun 13, 2019
@auto-label auto-label bot added the feature label Jun 13, 2019
iamareebjamal
iamareebjamal requested changes Jun 13, 2019
View reviewed changes
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not Needed

@adityastic adityastic closed this Jun 13, 2019
@adityastic adityastic reopened this Jun 14, 2019
@adityastic
Copy link
Collaborator Author

@yashk2000 @mariobehling review

@yashk2000
Copy link
Member

@adityastic can you remove the unsafe cast if possible?

@mariobehling
Copy link
Member

@iamareebjamal We need it to get the app ready for the Chinese app store.

@mariobehling mariobehling merged commit cee39f4 into fossasia:development Jun 15, 2019
@adityastic adityastic deleted the patch-366 branch June 15, 2019 14:28
@adityastic adityastic self-assigned this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal requested changes

@mariobehling mariobehling mariobehling approved these changes

Assignees

@adityastic adityastic

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make app multilanguage capable
4 participants
@adityastic @yashk2000 @mariobehling @iamareebjamal