Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG image #155

Closed
5 tasks done
niccokunzmann opened this issue Sep 22, 2017 · 21 comments · Fixed by #167, #176 or #476
Closed
5 tasks done

Use SVG image #155

niccokunzmann opened this issue Sep 22, 2017 · 21 comments · Fixed by #167, #176 or #476

Comments

@niccokunzmann
Copy link
Member

niccokunzmann commented Sep 22, 2017

I'm submitting a ...

  • feature request

Current behavior:

Currently, we can choose from a variety of badge backgrounds.
#152 introduced a new background picture.

Expected behavior:

Please allow an option to

  • (1) choose this background picture
  • (2) set the desired color
  • (3) set an image for the conference
  • (4) set a heading like "Speaker" or VIP

Steps to reproduce:

This is a multi-issue. If you like to work in it, please say, which part you like to work on.

@pushkalkatara
Copy link
Member

I would like to work on this issue, to add this image to the available list and printing badges.

@niccokunzmann
Copy link
Member Author

@pushkalkatara Sure :)

@rupav
Copy link
Member

rupav commented Sep 23, 2017

@niccokunzmann @pushkalkatara I think this issue is a part of issue#153 , which also asks for color changing bakground option for different types of tickets. So @pushkalkatara, I would like to collaborate with you on this and #153.

@pushkalkatara
Copy link
Member

@rupav Awesome 👍

@pushkalkatara
Copy link
Member

@rupav As you are familier with inkscape and making svgs, can you create a new svg with the background you generated, with the fossasia cover. Example -
businesspass

@rupav
Copy link
Member

rupav commented Sep 23, 2017

@pushkalkatara, yes I will get this done ASAP :)

@rupav
Copy link
Member

rupav commented Sep 23, 2017

@pushkalkatara I am done with putting "FOSSASIA" on top. Should i send a PR?

@gabru-md
Copy link
Member

gabru-md commented Sep 23, 2017

@niccokunzmann I can try working on "setting the desired color to the image in #152" using web gui

@pushkalkatara
Copy link
Member

@rupav You should add a text element also, to write headings like speaker, buisness pass etc.

@rupav
Copy link
Member

rupav commented Sep 23, 2017

@pushkalkatara , I have sent a PR. It also incorporates required Headings :)

@gabru-md
Copy link
Member

Reopened Issue

@gabru-md gabru-md reopened this Sep 23, 2017
@pushkalkatara
Copy link
Member

I am working further on this issue :D

@rupav
Copy link
Member

rupav commented Sep 25, 2017

@gabru-md @palnabarun you can reopen this issue, as 3rd point in the checklist still need to be done.

@vaibhavsingh97
Copy link
Member

vaibhavsingh97 commented Sep 25, 2017

@rupav Reopened 👍

@rupav
Copy link
Member

rupav commented Sep 25, 2017

hi @pushkalkatara @vaibhavsingh97. Following were the suggestions added in last two PRs related to this issues:
1). -Shifting to process to generate pngs through svgs for modularity rather then selecting pre-built pngs.
-This could solve problems like size of badges etc, all the problems related to design of badges.

2). Challenges ahead:
To change the height and width of the badge. Its difficult in the sense that voronoi triangles are not rectangular bounded, so their height/width change is still a task to do. Give your suggestion please.

So is it good if these are here only in the comment section or should I add a issue for this?

@vaibhavsingh97
Copy link
Member

@rupav I think we should go with first one. Please open a new issue so that we can discuss there 😄

@rupav
Copy link
Member

rupav commented Sep 26, 2017

Hi @vaibhavsingh97 . The first suggestion was written by @pushkalkatara . So It will be better to let him post, and explain the problem more clearly :). Albeit me and @pushkalkatara are working on these issues, all we need are opinions/suggestions of the community :).

@gabru-md
Copy link
Member

gabru-md commented Nov 2, 2017

@ParthS007 @S2606 @vaibhavsingh97 What is the progress of this issue ?

@k4ni5h
Copy link

k4ni5h commented Nov 28, 2017

What is the status of this issue ?

@niccokunzmann
Copy link
Member Author

Seems there is no progress. You can just go for it.

@ParthS007
Copy link
Member

ParthS007 commented Jan 21, 2018

closing this issue as the remaining 4th point was fixed in #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants