Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-1853 Implementing Font Color Selection on FrontEnd #1854

Closed
wants to merge 2 commits into from
Closed

Fix-1853 Implementing Font Color Selection on FrontEnd #1854

wants to merge 2 commits into from

Conversation

championpaddler
Copy link
Member

@championpaddler championpaddler commented Nov 1, 2018 •
edited
Loading

Fixes #1853

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

ezgif com-video-to-gif 1

  • Implementing Different Color Selection

rajvaibhavdubey
rajvaibhavdubey requested changes Nov 2, 2018
View reviewed changes
Copy link
Member

@rajvaibhavdubey rajvaibhavdubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the required changes, else LGTM 👍

frontend/app/templates/components/text-component/font-size.hbs Show resolved Hide resolved
@ParthS007
Copy link
Member

@sk9331657 LGTM. Please remove the individual Font color as It will be not required after this PR. 👍

@ParthS007
Copy link
Member

@sk9331657 Please update the PR asap.

@championpaddler
Copy link
Member Author

@ParthS007 Will do that asap. I have exams till 11 th.

@championpaddler
Copy link
Member Author

@ParthS007 Done Changes.

@ParthS007
Copy link
Member

@sk9331657 Color Picker is overlapping the slider. Please look into it. 👍

@championpaddler
Copy link
Member Author

@sk9331657 Color Picker is overlapping the slider. Please look into it. 👍

Checking that and also working on fixing with the backend.

@championpaddler
Copy link
Member Author

@ParthS007 @gabru-md Head over here to review this #1880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajvaibhavdubey rajvaibhavdubey rajvaibhavdubey requested changes

@samagragupta samagragupta samagragupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing Font Color Selection on FrontEnd
4 participants
@championpaddler @ParthS007 @samagragupta @rajvaibhavdubey