Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes#925 : Integrated wrapper for showing event notifications #932

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fixes#925 : Integrated wrapper for showing event notifications #932

merged 1 commit into from
Jun 4, 2018

Conversation

ParthS007
Copy link
Member

@ParthS007 ParthS007 commented Jun 4, 2018 •
edited
Loading

Fixes #925

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Integrated wrapper for showing event notifications
  • Integrated ember notify for the same.
  • A screenshot of the success Message.
    screenshot from 2018-06-04 21-57-09

gabru-md
gabru-md approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@gabru-md gabru-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yashLadha
yashLadha approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@yashLadha yashLadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djmgit djmgit merged commit 6d75b4a into fossasia:development Jun 4, 2018
@ParthS007 ParthS007 deleted the notify branch June 4, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmgit djmgit djmgit approved these changes

@yashLadha yashLadha yashLadha approved these changes

@gabru-md gabru-md gabru-md approved these changes

Assignees

@ParthS007 ParthS007

Labels
ready-to-ship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Wrapper for event messages in frontend
4 participants
@ParthS007 @djmgit @yashLadha @gabru-md