Add snackbar#1950, Dialog UI#1953 reducer, action, action creator #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshatnitd
requested changes
Jan 17, 2019
src/redux/actions/snackbar.js
Outdated
| @@ -0,0 +1,25 @@ | |||
| import { handleActions } from 'redux-actions'; | |||
| import actionTypes from '../actionTypes'; | |||
There was a problem hiding this comment.
Do need a separate file for this. It can be combined with the dialog box reducers.
There was a problem hiding this comment.
@akshatnitd The reason for keeping a separate file is, snackbar is used in more components, where dialog box is not used. Just to keep the imports less, so I split the reducers in to 2. If you want, I can combine them, or we can use 2 separate reducer
There was a problem hiding this comment.
I'll go with your approach, and make a single file
src/redux/actions/dialog.js
Outdated
| import actionTypes from '../actionTypes'; | ||
|
|
||
| const defaultState = { | ||
| openLogin: false, |
There was a problem hiding this comment.
Keep the state as -
modalProps: {
isModalOpen : false,
modalType: ''
},
snackBarProps : {
isSnackBarOpen: false,
snackBarMessage: ''
}
src/redux/actions/dialog.js
Outdated
|
|
||
| export default handleActions( | ||
| { | ||
| [actionTypes.UI_OPEN_LOGIN_DIALOG](state) { |
There was a problem hiding this comment.
Make changes in the actions and reducers accordingly.
fragm3
force-pushed
the
first-ui-global
branch
from
9dcb727
to
37bd111
Compare
|
@akshatnitd made the changes 👍 , please review |
Pipe-Runner
approved these changes
Jan 18, 2019
samagragupta
approved these changes
Jan 20, 2019
Akshat-Jain
approved these changes
Jan 20, 2019
AvinashAgarwal14
pushed a commit
to AvinashAgarwal14/chat.susi.ai
that referenced
this pull request
Jan 21, 2019
pulkit1joshi
pushed a commit
to pulkit1joshi/susi.ai
that referenced
this pull request
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1953, #1950
Changes:
Add reducers, action, action creator for redux integration for the following:
Demo Link: https://pr-1959-1-fossasia-susi-web-chat.surge.sh