-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-32: Change default settings for background color, invoice attachments and name scheme #156
Conversation
lcduong
commented
Jun 12, 2024
•
edited
Loading
edited
Change default settings for background color, invoice attachments and name scheme
Change default settings for background color, invoice attachments and name scheme
Hi @mariobehling @norbusan , changes for default background color is done, please help me to review and merge it. |
@@ -1,3 +1,7 @@ | |||
/* before variables.scss because it only affects presale, not control */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* before variables.scss as it affects presale only, not control */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mariobehling, text is updated.
@@ -453,6 +453,8 @@ def set_defaults(self): | |||
self.settings.ticketoutput_pdf__enabled = True | |||
self.settings.ticketoutput_passbook__enabled = True | |||
self.settings.event_list_type = 'calendar' | |||
self.settings.invoice_email_attachment = True | |||
self.settings.name_scheme = 'given_family' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think link 457 should be added in a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mariobehling , did not get your point, name_schema 'given_family' is default for new event, what need to be change?
comment text update