feature-32: Change default settings for background color, invoice attachments and name scheme #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lcduong
commented
Jun 12, 2024
•
lcduong
commented
Change default settings for background color, invoice attachments and name scheme
Change default settings for background color, invoice attachments and name scheme
|
Hi @mariobehling @norbusan , changes for default background color is done, please help me to review and merge it.
|
mariobehling
requested changes
Jun 12, 2024
| @@ -1,3 +1,7 @@ | |||
| /* before variables.scss because it only affects presale, not control */ | |||
There was a problem hiding this comment.
/* before variables.scss as it affects presale only, not control */
There was a problem hiding this comment.
Hi @mariobehling, text is updated.
| @@ -453,6 +453,8 @@ def set_defaults(self): | |||
| self.settings.ticketoutput_pdf__enabled = True | |||
| self.settings.ticketoutput_passbook__enabled = True | |||
| self.settings.event_list_type = 'calendar' | |||
| self.settings.invoice_email_attachment = True | |||
| self.settings.name_scheme = 'given_family' | |||
There was a problem hiding this comment.
I think link 457 should be added in a follow up PR.
There was a problem hiding this comment.
Hi @mariobehling , did not get your point, name_schema 'given_family' is default for new event, what need to be change?
comment text update
mariobehling
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.