Handle empty response from server in Loklak Fetcher #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Maintainers: @hoangvanthien did not provide a live link, one can be found at https://hoangvanthien.github.io/gci16.fossasia.org Generated by 🚫 danger |
skywrapper
pushed a commit
to skywrapper/gci16.fossasia.org
that referenced
this pull request
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your pull request! Please read and understand everything below
Please acknowledge that you have read and understood each of the following before submitting your pull request.
Do not delete any text other than where you are instructed.
Maintainers: If any of these are left unchecked, do not merge.
Students: If one of them is not applicable to you -- Please check it anyways. DO NOT REMOVE ANYTHING!
You may check them after opening your pull request.
You may do so by changing each
[ ]to[x]Please take note of the whitespace as it matters.240 x 240[w x h]Things done in this Pull Request
I encounter an error of empty response issued in #880 (I made it strikethrough since it doesn't seem an error of our website).
However, in this case, I strongly suggest that we must halt the parsing function instead of continuing with empty object. See more in file changes.