Fixed navbar linking issue #99 and added performance improvements #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added preload= none to the video file so that it doesn't add time in loading of the page -linked the The options of navbar to right section of the page.
fragm3
reviewed
Oct 28, 2018
_includes/header.html
Outdated
| @@ -39,7 +39,7 @@ | |||
| <li><a href="#welcome">Welcome</a></li> | |||
| <li><a href="#mentors">Mentors</a></li> | |||
| <li><a href="#students">Students</a></li> | |||
| <li><a href="#projects">Projects</a></li> | |||
| <li><a href="/projects.html">Projects</a></li> | |||
There was a problem hiding this comment.
Why /project.html? Correct it.
|
IS it not the student's projects? @fragm3 |
|
@Sid911 its supposed to be a section like Mentors, do those changes and we are good to merge this. |
|
working on it 😊 |
Changed the link to /index.html#section_name so that it can be accessed from anywhere
|
@fragm3 done |
|
@Sid911 why have you add '/' in front, it wont work if you put '/' |
This reverts commit fcda673.
fragm3
reviewed
Oct 28, 2018
_includes/header.html
Outdated
| <li><a href="#mentors">Mentors</a></li> | ||
| <li><a href="#students">Students</a></li> | ||
| <li><a href="#projects">Projects</a></li> | ||
| <li><a href="/#welcome">Welcome</a></li> |
There was a problem hiding this comment.
only "welcome"(no /), same for below 3 lines
This reverts commit 844377c.
|
@fragm3 done😊......... |
|
@fragm3 This PR was merged without a minimum of 2 approvals. Also, please ensure to approve yourself before merging. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done in this Pull Request
preload="metadata"to the videos, so that it doesn't hamper the loading timesDescription / Changes
The navbar is now functional and the loading time has been improved.