-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed navbar linking issue #99 and added performance improvements #100
Conversation
- Added preload= none to the video file so that it doesn't add time in loading of the page -linked the The options of navbar to right section of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment, rest looks good to me.
_includes/header.html
Outdated
@@ -39,7 +39,7 @@ | |||
<li><a href="#welcome">Welcome</a></li> | |||
<li><a href="#mentors">Mentors</a></li> | |||
<li><a href="#students">Students</a></li> | |||
<li><a href="#projects">Projects</a></li> | |||
<li><a href="/projects.html">Projects</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why /project.html? Correct it.
IS it not the student's projects? @fragm3 |
@Sid911 its supposed to be a section like Mentors, do those changes and we are good to merge this. |
working on it 😊 |
Changed the link to /index.html#section_name so that it can be accessed from anywhere
@fragm3 done |
@Sid911 why have you add '/' in front, it wont work if you put '/' |
This reverts commit fcda673.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment
_includes/header.html
Outdated
<li><a href="#mentors">Mentors</a></li> | ||
<li><a href="#students">Students</a></li> | ||
<li><a href="#projects">Projects</a></li> | ||
<li><a href="/#welcome">Welcome</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only "welcome"(no /), same for below 3 lines
This reverts commit 844377c.
@fragm3 done😊......... |
@fragm3 This PR was merged without a minimum of 2 approvals. Also, please ensure to approve yourself before merging. Thanks |
Changes done in this Pull Request
preload="metadata"
to the videos, so that it doesn't hamper the loading timesDescription / Changes
The navbar is now functional and the loading time has been improved.