Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#193) Fixed the navbar links on the student projects page #194

Merged
merged 1 commit into from
Nov 3, 2018
Merged

(#193) Fixed the navbar links on the student projects page #194

merged 1 commit into from
Nov 3, 2018

Conversation

AppleC4T
Copy link
Contributor

@AppleC4T AppleC4T commented Nov 3, 2018

Check by changing each [ ] to [x] Please take note of the whitespace as it matters.

  • Included a Preview link and screenshot showning after and before the changes.
  • Included a description of change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

Fixed the links bug on the student projects page causing them not to link back to the home page. Changed the header so that the links are precise and can link back to the main page on any sub-page.

@Pipe-Runner
Copy link

@AppleC4T Could you make one more change? The order of mentor and student in the nav bar should be swapped because they appear to be in the opposite order of the way they are in the actual HTML page. Rest seems to be working pretty good. Good job spotting the bug.

@AppleC4T
Copy link
Contributor Author

AppleC4T commented Nov 3, 2018

@AakashMallik Here you go. Thanks for the feedback. 😄

Copy link
Member

@saarthakchats saarthakchats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating another header file, you should simply change the links in such a way so that it works for all pages

@AppleC4T
Copy link
Contributor Author

AppleC4T commented Nov 3, 2018

@saarthakchats here you go.

@Pipe-Runner
Copy link

@saarthakchats Good call.

@AppleC4T
Copy link
Contributor Author

AppleC4T commented Nov 3, 2018

Is it good to merge now?

@abishekvashok abishekvashok merged commit ae7e07a into fossasia:master Nov 3, 2018
@abishekvashok
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants