-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Layout to make code DRY #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niteshkumarniranjan Footer is good, header section has some changed css properties like background color, logo, font. Fix header.
@fragm3 I have just removed a class thats why this is and about the logo I think this logo looks better in a single line rather than having two line logo. |
@fragm3 I have been doing UI/UX designs for more than a year and I think that having a light background adds contrasts so that people see the Banner first not the header. |
@niteshkumarniranjan The drop menu is of grey, I think grey is still better as most of the webpage is white, so grey adds contrasts. Not sure about the icon @mariobehling, thoughts? |
@niteshkumarniranjan It's better to stick to one issue per PR, you can create a separate issue, if you want to make other changes(UI/UX). |
@fragm3 Reverted back to gray menu. |
@niteshkumarniranjan one PR for one issue. Make it exactly same, you can create new enhancement issues for improvements. Helps us keep track of work you have done, quick code review. |
@fragm3 I have reverted back to gray menu so there is only one issue being addressed. |
What exactly does DRY Mean ? |
Don't repeat yourself @YashKumarVerma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a picture of a boy for the favicon?
@saarthakchats that favicon wiil not appear in the website. that favicon is there because of my portfolio being hosted in by github. |
Okay cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve conflicts.. rest looks good
Couldn't get you |
@YashKumarVerma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just squash your commits. LGTM
@saarthakchats I cann't if I will squash now conflict will be back. |
Why do you delete index html? |
@tabesin I haven't deleted index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash all three commits to Split Layout Files (#16)
. And rebase it with upstream for getting merged.
@niteshkumarniranjan can you confirm this pr also closes #27 ? |
@realslimshanky Nope! That's another issue. |
Please read and understand everything below
Do not delete any text other than where you are instructed.
Students: If one of them is applicable to you. Please check it.
Check by changing each
[ ]
to[x]
Please take note of the whitespace as it matters.Changes done in this Pull Request
gh-pages
)Description / Changes
Splitted Header and Footer into separate files to make it DRY.