-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added my own bg music and tile music #810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you properly license these content as well?
@abishekvashok I think licensing is not required.
it's only needed if I don't like to change it by others. So I think it's not required. |
Please choose one. |
@abishekvashok OK. I added one. |
If you do not add a license, the song is GPL licensed. |
@niccokunzmann I added licenses. Please, could you merge this now? |
I had a look at the files. You are proposing to use WAV which is uncompressed and huge. This makes cloning the repository slower. Would it be ok for you to add it in e.g. ogg format? |
@niccokunzmann I converted them to .ogg format thank you! |
Thanks! |
Thank you! |
Changes done in this Pull Request