Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my own bg music and tile music #810

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Conversation

supunTE
Copy link
Member

@supunTE supunTE commented Nov 8, 2018

  • Read and understood [see CONTRIBUTING.md]
  • Included a preview link and screenshot showing after and before the changes.
  • Included a description of change below.
  • Tried to squash.

Changes done in this Pull Request

Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you properly license these content as well?

@supunTE
Copy link
Member Author

supunTE commented Nov 9, 2018

@abishekvashok I think licensing is not required.
As the task said,

we recommend choosing the license CC-BY or CC-BY-SA if you like others to remix or CC-BY-ND if you do not like people editing your song.

it's only needed if I don't like to change it by others. So I think it's not required.
@niccokunzmann What's your idea?

@abishekvashok
Copy link
Member

Please choose one.

@supunTE
Copy link
Member Author

supunTE commented Nov 9, 2018

@abishekvashok OK. I added one.

@niccokunzmann
Copy link
Member

If you do not add a license, the song is GPL licensed.

@supunTE
Copy link
Member Author

supunTE commented Nov 10, 2018

@niccokunzmann I added licenses. Please, could you merge this now?

@niccokunzmann
Copy link
Member

I had a look at the files. You are proposing to use WAV which is uncompressed and huge. This makes cloning the repository slower. Would it be ok for you to add it in e.g. ogg format?

@supunTE
Copy link
Member Author

supunTE commented Nov 10, 2018

@niccokunzmann I converted them to .ogg format thank you!

@niccokunzmann niccokunzmann merged commit ae3d843 into fossasia:master Nov 10, 2018
@niccokunzmann
Copy link
Member

Thanks!

@abishekvashok
Copy link
Member

@supunTE
Copy link
Member Author

supunTE commented Nov 16, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants