Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #219 : 404 page #225

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Fixes #219 : 404 page #225

merged 1 commit into from
Jan 19, 2017

Conversation

Achint08
Copy link
Member

@Achint08 Achint08 commented Jan 18, 2017 •
edited
Loading

Kindly check and review.
gh-pages- https://achint08.github.io/loklak_search/

jigyasa-grover
jigyasa-grover reviewed Jan 18, 2017
View reviewed changes
Copy link
Member

@jigyasa-grover jigyasa-grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @hemantjadon your input pls.

abishekvashok
abishekvashok approved these changes Jan 18, 2017
View reviewed changes
Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hemantjadon
hemantjadon suggested changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@hemantjadon hemantjadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works fine.

Just change the name of the module and component CamelCase

@Achint08
404 component
413b104 
404 Page Not found
404 page

minor errors

minor errors

minor changes
@jigyasa-grover jigyasa-grover merged commit b47abbb into fossasia:master Jan 19, 2017
@Achint08 Achint08 mentioned this pull request Jan 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigyasa-grover jigyasa-grover jigyasa-grover left review comments

@hemantjadon hemantjadon hemantjadon requested changes

@abishekvashok abishekvashok abishekvashok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Achint08 @abishekvashok @jigyasa-grover @hemantjadon