Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #270 , #271 , #272 #254 : API request for aggregation #274

Merged
merged 1 commit into from
Feb 11, 2017

Conversation

Achint08
Copy link
Member

@Achint08 Achint08 commented Feb 11, 2017

Fixes #270 ,#271 , #272 , #254 : Implements seperate API request for Aggregation

Changes proposed in this pull request
Separate request for aggregations have been made to get aggregation and avoid search service crash.
Now the aggregation service will work again and
-> Side Bar will work again
-> Show more will work.
-> Pagination will work properly

Screenshots (if appropriate)

Link to live demo (if appropriate):
Checkout here.

**Closes #270 , #271 , #272, #254 **

@Achint08 Achint08 changed the title Fixes #270 , #271 , #272 : API request for aggregation Fixes #270 , #271 , #272 #254 : API request for aggregation Feb 11, 2017
@mariobehling
Copy link
Member

mariobehling commented Feb 12, 2017

Not sure, what has changed, but now I also see issues on your the test page. Wonder why I have not seen it earlier.

screenshot from 2017-02-12 12-31-53

@Achint08
Copy link
Member Author

Achint08 commented Feb 12, 2017

@mariobehling I will look forward to fix this. Actually , the problem is that sometimes server doesn't respond and then if some variable goes undefined search service crash.

@mariobehling
Copy link
Member

sometimes server doesn't respond

The idea for this was to show a loading icon instead of empty areas.

But, how could we know if the server responds or not? Is there a way to see errors? How do you know that?

I am also unclear why this affects the page design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants