Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #876: Reduce load time to increase speed of various components #877

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

simsausaurabh
Copy link
Member

@simsausaurabh simsausaurabh commented Jul 24, 2018

Changes proposed in this pull request

  • Removed unwanted and unused CSS from each component.

Screenshots (if appropriate)

Link to live demo: http://pr-877-fossasia-loklaksearch.surge.sh

Closes #876
Addresses: #716

@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #877 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           development    #877   +/-   ##
===========================================
  Coverage         50.7%   50.7%           
===========================================
  Files              106     106           
  Lines             2619    2619           
  Branches           295     295           
===========================================
  Hits              1328    1328           
  Misses            1263    1263           
  Partials            28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84465fc...9427640. Read the comment docs.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simsausaurabh For screen width less than 1180px sidebar goes down and overflows on right side.
image
It is fine in bottom but make sure its right border do not go outside the screen.

@simsausaurabh
Copy link
Member Author

@praveenojha33 This PR is not in reference to that. The thing you are proposing, I am working from earlier and would be fixed in PR: #799

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mariobehling mariobehling merged commit 59faa0a into fossasia:development Jul 24, 2018
@simsausaurabh simsausaurabh deleted the speed branch July 24, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants