Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #905: Add badgeyay inside service-box #906

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

simsausaurabh
Copy link
Member

Changes proposed in this pull request

  • Added badgeyay logo inside assets/images/ folder.
  • Added link to badgeyay inside service-box.
  • Added root link to badgeyay in url-config.

Screenshots (if appropriate)

Link to live demo: http://pr-906-fossasia-loklaksearch.surge.sh

Closes #905

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #906 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #906   +/-   ##
============================================
  Coverage        50.67%   50.67%           
============================================
  Files              109      109           
  Lines             2674     2674           
  Branches           301      301           
============================================
  Hits              1355     1355           
  Misses            1287     1287           
  Partials            32       32
Impacted Files Coverage Δ
src/app/shared/url-config.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a278a1...dbb8cb6. Read the comment docs.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mariobehling mariobehling merged commit 15dc391 into fossasia:development Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants