-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check availability of profile pictures and fail-over option #59
Comments
the placeholder images had been uploaded with commit 23a6223 |
This feature will be supported by loklak_server issue loklak/loklak_server#31 |
@Orbiter, this is now ready from the front end.
Please open this issue again when server is ready, and comment here if the query url structure changes. |
Ok I will reopen this issue as soon as loklak/loklak_server#31 is implemented |
This is the back-end implementation to support fossasia/loklak_webclient#59
The backend issue loklak/loklak_server#31 is implemented. Please use the following URL to access the cache on the server-side:
This means you must submit two parameters to the
|
The latest version of loklak_server can now attach images inside the user information encoded with base64. Therefore, the following task shall be done in front of the process as described in #59 (comment)
|
the complete process now is:
|
I did a quick test and the result is that, for user of image request from twitter failed, requests to loklak server will fail too. Quick demonstration: here I have search listing accounts, so I'd know which to test.http://gofullstack.me:3001/search?q=%23loklak%2B%2Faccounts&timezoneOffset=-180 Images those are unsuccessfully loaded from twitter, would deal with the same result from loklak:
Images those are successfuly loaded, can be requested again from loklak: |
@Orbiter , @fuksi this can be a possible solution: http://avatars.io/ Edit: The service is in beta, and it is an external dependency. We don't know if they will be present or change in the future. But for now, it works. |
Additionally this page tells us why we are getting these errors: Possible solution:Whenever the image is not received, call the twitter api to get the latest url. This call can be made through:
|
Great find @aneeshd16 But I think its better if the loklak_server does this than the client, that way we know that the server always has the updated images, Maybe it could be a cron service which runs regularly to make these updates. What do you think @fuksi @Orbiter @prasht63 ? |
a cronjob or similar is out of question. We already have over 8 million users in our database and there is no point checking them all the time. |
@aneeshd16 Yes, great find, but this app is in Beta and we probably have to pay later. I do not think it is magic to get avatars from Twitter and if that does not work from Gravatar. Supporting Gravatar should be a feature for the future anyways. Not sure, if that is high on the list right now. What we need is a working prototype to get users. So, the current approach seems sufficient. |
As the implementation here is ongoing, I do not understand why this issue is closed. I am reopening it and assign it to M2. If this issue is supposed to be closed, please explain why and create a new issue for a specific feature instead of continuing on a closed issue. |
Oh sorry. I think I got confused by the label "closed" at some point. I see that this issue is open, but it was not in M2 yet. Cheers. |
The image will be provided by the loklak_server using @aneeshd16 idea to load the latest url from twitter directly. This requires that a twitter api library must be included in the loklak_server (shall be done anyway) to load that information. The issue is tracked with loklak/loklak_server#51 While this is implemented, this feature is in hold-on state. If the proxy provides this function, it can be re-tested and if working this feature can be closed without any more coding on client side. |
This is now moved to milestone 3 until further support. |
The supporting feature has been implemented with loklak/loklak_server#51 I wonder why this feature has not been used so far, because it should have helped in the most cases already. I can see in the log that the proxy-servlet had not been called once, ever! Here is an example call: If the image url is unknown or has changed, the proxy servlet will find it out itself. |
@Orbiter M3 is closed. So, I moved it to M3.5. |
I think this is already implemented, any images which fail to load, use the image at @fuksi Please confirm. |
This feature shall be implemented for the search page but shall also be applicable for all other places in loklak_webclient, where a profile image is needed.
We currently have the problem that some profile pictures are not loaded from Twitter in all cases. In case that a load from twitter is not possible, we need an alternative image. That image shall be provided by the loklak_server back-end.
The following process shall be implemented:
The request to the back-end must contain the screen_name of the user.
The text was updated successfully, but these errors were encountered: