Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing the way to send the wallpaper, logo, and zipfiles from the webapp to build server #398

Closed
1 of 3 tasks
pranav1698 opened this issue Feb 8, 2019 · 8 comments · Fixed by #425
Closed
1 of 3 tasks
Labels

Comments

@pranav1698
Copy link

pranav1698 commented Feb 8, 2019

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/meilix

Expected Behaviour
In the current build, wallpaper in stored in the wallpapers folder in the server and previously this was accessed during the build by accessing https://meilix-generator.herokuapp.com/. This can cause same wallpaper for two different users which have build the ISO using the generator.

Would you like to work on the issue?
Open

@xeon-zolt
Copy link
Member

xeon-zolt commented Feb 10, 2019

you are talking about race condition yes it can happen you can send wallpaper in the API as base64 and keep storing them in with a random name lets say we use uuid for that

@pranav1698
Copy link
Author

I have tried the idea of sending the wallpaper to the API encoding with base64, that happens after #396 is merged, but I have not tested the wallpaper

@tabesin
Copy link
Member

tabesin commented Feb 11, 2019

Please also keep @meets2tarun in the loop and let's experiment.

@pranav1698
Copy link
Author

@tabesin @xeon-zolt I have tried sending the wallpaper as an encoded base64 string,
The problem is that the base64 strings will be so big for a large image that when this will be send to the server as an environment variable, it becomes an unbound variable and cannot be stored in bash script so the build gives a error.
The method would work for a smaller image (<500 KB) but it will not work for a bigger image,
We need different way to store these base64 encoded strings in the server or a different way to send the binary files

@xeon-zolt
Copy link
Member

I have a plan

  1. user will upload an image for wallpaper
  2. then we upload it to transfer.sh
  3. then we get a link from transfer.sh
  4. then we send that link to Travis ci
  5. Travis ci will download from transfer.sh
  6. build iso using the downloaded wallpaper

@xeon-zolt
Copy link
Member

aww-board

@tabesin
Copy link
Member

tabesin commented Feb 22, 2019

If you implement third party services for practical reasons also ensure that the mechanism works without that service. That is the basic proof of concept must be without such external dependencies. If they are added then in a way that you could disable them without coding.

@xeon-zolt
Copy link
Member

xeon-zolt commented Feb 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants