-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing the way to send the wallpaper, logo, and zipfiles from the webapp to build server #398
Comments
you are talking about race condition yes it can happen you can send wallpaper in the API as base64 and keep storing them in with a random name lets say we use uuid for that |
I have tried the idea of sending the wallpaper to the API encoding with base64, that happens after #396 is merged, but I have not tested the wallpaper |
Please also keep @meets2tarun in the loop and let's experiment. |
@tabesin @xeon-zolt I have tried sending the wallpaper as an encoded base64 string, |
I have a plan
|
If you implement third party services for practical reasons also ensure that the mechanism works without that service. That is the basic proof of concept must be without such external dependencies. If they are added then in a way that you could disable them without coding. |
I too have fear of being reliable on third-party service so we can do one
thing can add multiple services like these and use try-except block so in
case anyone is down other will be automatically be used
|
I'm submitting a ... (check one with "x")
Expected Behaviour
In the current build, wallpaper in stored in the wallpapers folder in the server and previously this was accessed during the build by accessing
https://meilix-generator.herokuapp.com/
. This can cause same wallpaper for two different users which have build the ISO using the generator.Would you like to work on the issue?
Open
The text was updated successfully, but these errors were encountered: