Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix navbar #359

Closed
wants to merge 1 commit into from
Closed

fix navbar #359

wants to merge 1 commit into from

Conversation

pythongiant
Copy link
Member

@pythongiant pythongiant commented Dec 5, 2018

fix navbar

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • There is a corresponding issue for this pull request.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (provide a screenshot or link for test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

Fix the navbar

Changes proposed in this pull request:

Fix Navbar for mobile devices
screenshot_3

-https://gentle-beyond-35732.herokuapp.com/

Fixes #355

Copy link

@pranav1698 pranav1698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot_20181205_224458
The container for dropdown is bigger, hence the labs.fossasia.org is not fitting into it
screenshot_20181205_224513
Please align the menu button for mobile devices

fix navbar

fix navbar
@pythongiant
Copy link
Member Author

@pranav1698 check it out now?

Copy link

@pranav1698 pranav1698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot_20181206_183132
The drop-down menu is coming out of the upper and the right border,
screenshot_20181206_183056
You can also see it is in the case of the bottom-most border
screenshot_20181206_183124
Take an example of susper, the drop-down seems well fitting inside the container

@pythongiant
Copy link
Member Author

@pranav1698 i dont follow

@pythongiant
Copy link
Member Author

LGTM on my screen

@pranav1698
Copy link

have you checked it on your phone
Open susper for comparison you will see the difference it may here because of white background

@pythongiant
Copy link
Member Author

ummm @pranav1698 that's due to the fact that there are more icons in this dropdown

@pranav1698
Copy link

So you can increase the size of the drop-down container to fit in with the total number of the items,

@supunTE supunTE mentioned this pull request Dec 6, 2018
6 tasks
@pythongiant
Copy link
Member Author

@pranav1698 i am gonna add a scrolbar if that's fine?

@pythongiant
Copy link
Member Author

nevermind closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Dropdown menu and the menu button is not responsive for mobiles
2 participants