Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added features required for the event-os #68

Closed
wants to merge 22 commits into from
Closed

Added features required for the event-os #68

wants to merge 22 commits into from

Conversation

meets2tarun
Copy link
Member

@meets2tarun meets2tarun commented Jun 24, 2017

Short Description

I have:

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

Configured the generator branch to add lxqt and added chromium config(all are tested and working) and the required meta package as mentioned in the issue.

@xeon-zolt
Copy link
Member

locally tested ?

@meets2tarun meets2tarun changed the title Desktop Added features required for the event-os Jun 24, 2017
@abishekvashok
Copy link
Member

abishekvashok commented Jun 24, 2017

Reviewers please pull and test it locally

Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but a few concerns

.travis.yml Outdated
@@ -5,7 +5,6 @@ sudo: required

script:
- ./build.sh
- 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then bash ./scripts/aptRepoUpdater.sh; fi'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need this as the meilix PPA should get updated with the new sources.

Standards-Version: 3.9.2

Package: event-metapackage
# Version: <enter version here; defaults to 1.0>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enter a version.

xfce4-mixer gstreamer0.10-alsa pulseaudio pavucontrol lxpanel \
mozilla-plugin-vlc lubuntu-core jockey-gtk

apt-get -q -y --purge install lxqt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add openbox

Copy link
Member

@xeon-zolt xeon-zolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are these gonna be edited by webapp
is a question
i have achieved firefox using webapp
it would be good if you just go with lxqt only in this pull request

@meets2tarun
Copy link
Member Author

meets2tarun commented Jun 25, 2017

i have achieved firefox using webapp
it would be good if you just go with lxqt only in this pull request

Continue customizing the firefox config using webapp
I would check lxqt config too
This PR will fix the issue #67

@xeon-zolt
Copy link
Member

that is a Epic issue so it should be broken to parts !

user_pref("extensions.getAddons.cache.lastUpdate", 1498203354);
user_pref("extensions.getAddons.databaseSchema", 5);
user_pref("extensions.hotfix.lastVersion", "20170302.01");
user_pref("extensions.ieview.installTime", "Thu Jun 01 2017 19:57:00 GMT+0530 (IST)");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install time?

@meets2tarun meets2tarun deleted the desktop branch July 23, 2017 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants