Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Add contributing.md file link in readme file. #522

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

dipu989
Copy link
Contributor

@dipu989 dipu989 commented Oct 31, 2019

Fixes #521

Changes:
Added project setup instructions link in Readme.md file.

Screenshot/s for the changes:
NA

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
NA

@dipu989
Copy link
Contributor Author

dipu989 commented Oct 31, 2019

@jddeep @adityastic Please review this!

Copy link
Contributor

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, instead of docs, you can use chore

@dipu989 dipu989 changed the title documentation : Add contributing.md file link in readme file. chore : Add contributing.md file link in readme file. Oct 31, 2019
@dipu989
Copy link
Contributor Author

dipu989 commented Oct 31, 2019

Looks good, instead of docs, you can use chore

Changed it! Will keep this in mind from the next time 👍

@jddeep jddeep merged commit 9c80fa1 into fossasia:development Nov 1, 2019
@mariobehling
Copy link
Member

Reverting this as contributing.md was deleted. Standard setup procedures for Android apps are already documented elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Contributing.md link in Readme.md
4 participants