Make app exit on back press when events screen is opened from the welcome screen #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, if the user selected the "Use my current location" option in the welcome screen and pressed the back button in the newly opened events screen, he would see the welcome screen slide in partially for an instant. Then, he would be shown the events screen again. Thus, the back button wasn't working. This was because the welcome screen remained on the backstack. This commit fixes the issue and implements conditional navigation to the welcome screen like Google's docs recommend. Fixes: fossasia#992
|
Thank you :) |
nikit19
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #992
Changes: Earlier, if the user selected the "Use my current location" option in the welcome screen and pressed the back button in the newly opened events screen, he would see the welcome screen slide in partially for an instant. Then, he would be shown the events screen again. Thus, the back button wasn't working.
This was because the welcome screen remained on the backstack.
This commit fixes the issue and implements conditional navigation to the welcome screen like Google's docs recommend.