Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make app exit on back press when events screen is opened from the welcome screen #1098

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Make app exit on back press when events screen is opened from the welcome screen #1098

merged 3 commits into from
Feb 14, 2019

Commits on Feb 10, 2019

  1. fix: make app exit on back press on first-launch in events screen 

    Earlier, if the user selected the "Use my current location" option in
the welcome screen and pressed the back button in the newly opened
events screen, he would see the welcome screen slide in partially for an
instant. Then, he would be shown the events screen again. Thus, the back
button wasn't working.

This was because the welcome screen remained on the backstack.

This commit fixes the issue and implements conditional navigation to the
welcome screen like Google's docs recommend.

Fixes: fossasia#992
    @AnEnigmaticBug
    AnEnigmaticBug committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    b557631 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Merge branch 'development' into iss992

    @AnEnigmaticBug
    AnEnigmaticBug committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    1532e0b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Merge branch 'development' into iss992

    @AnEnigmaticBug
    AnEnigmaticBug committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a6ed7b5 View commit details
    Browse the repository at this point in the history