fix: Disable Google Credentials Sign In leading to crash #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private lateinit var thisActivity: Activity | ||
| private var credentialsClient: CredentialsClient? = null | ||
| private var signInClient: GoogleSignInClient? = null | ||
| private var thisActivity: Activity? = null |
There was a problem hiding this comment.
This is a very very poor implementation of ViewModel. I don't know what was I smoking when I let this get merged.
There are Android classes used in ViewModel. No doubt there was a crash 🤦♂️
Remove this feature completely and create an issue to reimplement this
Don't delete this ViewModel
addiegupta
force-pushed
the
1531-signup-crash
branch
from
b33896a
to
967a812
Compare
Fixes: fossasia#1531 Changes: - Removes the Smart Auth features to fix app crash. These will be reimplemented later SmartAuthViewModels files have not been deleted
addiegupta
force-pushed
the
1531-signup-crash
branch
from
967a812
to
e3a1602
Compare
iamareebjamal
approved these changes
Apr 4, 2019
iamareebjamal
changed the title
nikit19
approved these changes
Apr 4, 2019
2 tasks
|
@iamareebjamal Is anything else required in this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1531
Changes:
Screenshots for the change: