Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add skip button #1821

Merged
merged 1 commit into from
May 25, 2019
Merged

feat: Add skip button #1821

merged 1 commit into from
May 25, 2019

Conversation

anhanh11001
Copy link
Contributor

Details:

  • Add skip button in WelcomeFragment to move to EventsFragment directly

Fixes: #1817

Screenshots for the change:
ezgif-4-659baf1d6a05

@auto-label auto-label bot added the feature label May 25, 2019
liveHarshit
liveHarshit previously approved these changes May 25, 2019
View reviewed changes
@liveHarshit
Copy link
Member

Build is failing

@anhanh11001
Summary: Add skip button
313b3ce 
Details:

Add skip button in WelcomeFragment to move to EventsFragment directly
Fixes: #1817
@anhanh11001
Copy link
Contributor Author

Failing build fixed

@iamareebjamal iamareebjamal merged commit 1138bb8 into fossasia:development May 25, 2019
@anhanh11001 anhanh11001 deleted the 1817_skip_screen branch June 20, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@liveHarshit liveHarshit liveHarshit approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add skip screen to welcome fragment
3 participants
@anhanh11001 @liveHarshit @iamareebjamal