Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

every user is organizer for every event #6266

Closed
uds5501 opened this issue Feb 20, 2019 · 20 comments · Fixed by #6264
Closed

every user is organizer for every event #6266

uds5501 opened this issue Feb 20, 2019 · 20 comments · Fixed by #6264
Assignees
Labels

Comments

@uds5501
Copy link
Contributor

uds5501 commented Feb 20, 2019

Describe the bug

Please refer to the screen shot given below

Expected behavior

Only the events whom the user is actually an organiser should be displayed

Screenshots

image

Desktop (please complete the following information):

  • OS: [e.g. iOS] Ubuntu
  • Browser [e.g. chrome, safari] Chrome

Additional context

Working on it

@uds5501
Copy link
Contributor Author

uds5501 commented Feb 20, 2019

@iamareebjamal @CosmicCoder96 I think the problem lies in the fact that currently organizer_events relationship is having no validation checks as to whether the user is actually an organiser or not.

organizer_events = Relationship(
self_view='v1.user_organizer_event',
self_view_kwargs={'id': '<id>'},
related_view='v1.event_list',
schema='EventSchema',
many=True,
type_='event')

    organizer_events = Relationship(
        self_view='v1.user_organizer_event',
        self_view_kwargs={'id': '<id>'},
        related_view='v1.event_list',
        schema='EventSchema',
        many=True,
        type_='event')

How should I proceed to make sure that the Relationship actually checks whether the current user is an organiser in the event or not, I could use help in this

@abhinavk96 abhinavk96 transferred this issue from fossasia/open-event-frontend Mar 11, 2019
@prabhupant
Copy link
Contributor

@uds5501 are you still working on this?

@uds5501
Copy link
Contributor Author

uds5501 commented Mar 25, 2019

@prabhupant No I am not, but would like to provide a heads up. It's a FE issue. The relations are correct in the server but not in the frontend. If you want to take over, be my guest

@kushthedude
Copy link
Member

@uds5501 Transfer it to FE

@iamareebjamal iamareebjamal transferred this issue from fossasia/open-event-server Mar 25, 2019
@kushthedude
Copy link
Member

@uds5501 Wanted to know if the server is providing correct relation than Is it hardcoded for every user?

@uds5501
Copy link
Contributor Author

uds5501 commented Mar 26, 2019

@kushthedude the server side relationships are working fine. as I have already mentioned above :)

@Haider8
Copy link
Contributor

Haider8 commented Mar 26, 2019

@uds5501 Can i work on this issue ?

@kushthedude
Copy link
Member

@Haider8 Progress?

@Haider8
Copy link
Contributor

Haider8 commented Mar 31, 2019 via email

@Haider8
Copy link
Contributor

Haider8 commented Apr 2, 2019

@uds5501 @prabhupant I think this issue is not there anymore

@uds5501
Copy link
Contributor Author

uds5501 commented Apr 4, 2019

@Haider8 It is still there :)
image

@prateekj117
Copy link
Member

@uds5501 If you haven't spent much time on it, May I work on this issue?

@uds5501
Copy link
Contributor Author

uds5501 commented Apr 7, 2019

@prateekj117 Go for it!

@prateekj117
Copy link
Member

@uds5501 This problem doesn't seem to persist on my system.

@uds5501
Copy link
Contributor Author

uds5501 commented Apr 7, 2019 via email

@prateekj117
Copy link
Member

@uds5501 Yes, you are right. The problem persists.

@prateekj117
Copy link
Member

prateekj117 commented May 25, 2019

@CosmicCoder96 @iamareebjamal This is a temporary fix. I think that this issue is of the server as @uds5501 commented above. Can you please transfer this to the server so that I can do the permanent fix there.

@uds5501
Copy link
Contributor Author

uds5501 commented May 25, 2019

@prateekj117 this is an issue at the front-end only. Happening due to incorrect model relationships at ember model levels. The server side relations are working fine, I have verified

@prateekj117
Copy link
Member

@uds5501 Thanks for the info. In that case, I will look into it.

@abhinavk96 abhinavk96 self-assigned this Jun 9, 2019
@abhinavk96 abhinavk96 transferred this issue from fossasia/open-event-frontend Jul 30, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.86. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment