fix: Disallow speaker call start, end dates after event end date #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## development #1628 +/- ##
===============================================
- Coverage 24.33% 24.26% -0.08%
===============================================
Files 381 381
Lines 3439 3450 +11
===============================================
Hits 837 837
- Misses 2602 2613 +11
Continue to review full report at Codecov.
|
|
@srv-twry @mayank8318 @pradeepgangwar @ritikamotwani @schedutron Please review |
dr0pdb
approved these changes
Aug 12, 2018
abhinavk96
reviewed
Aug 12, 2018
| @@ -165,11 +165,28 @@ export default Mixin.create(MutableArray, CustomFormMixin, { | |||
| }); | |||
| }, | |||
|
|
|||
| validateEventDate(eventEndsAt, speakerCallStartsAt, speakerCallEndsAt) { | |||
| if (eventEndsAt && speakerCallStartsAt && eventEndsAt < speakerCallStartsAt) { return false } | |||
There was a problem hiding this comment.
why are two there three return statements to return a binary value? use OR operator .
| this.set('data.event.state', 'draft'); | ||
| this.sendAction('save'); | ||
| var isValidDate = true; | ||
| var eventEndsAt = this.get('data.event').get('endsAt'); |
There was a problem hiding this comment.
two consecutive gets. Should be this.get('data.event.endsAt');
| var isValidDate = true; | ||
| var eventEndsAt = this.get('data.event').get('endsAt'); | ||
| if (this.get('data.speakersCall')) { | ||
| var speakerCallStartsAt = this.get('data.speakersCall').get('startsAt'); |
There was a problem hiding this comment.
this.get('data.speakerCall.startsAt')
| this.set('data.event.state', 'draft'); | ||
| this.sendAction('save'); | ||
| } else { | ||
| this.get('notify').error('Invalid Start or End Date'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developmentbranch.Short description of what this resolves:
Shows notify error when Speaker Call start or end date is after Event end date.
Fixes #1156