feat: redesigns sessions page and add lock/unlock column #2964

shreyanshdwivedi · 2019-05-19T23:11:37Z

Short description of what this resolves:

Redesigns the session page and introduce lock/unlock column

Changes proposed in this pull request:

- Takes out "short abstract" column
- Moves the actions icons below "Title" and increase the size
- Adds a column "Track"
- Adds a column "Type" e.g. to distinguish workshops and talks
- Adds column with an icon to lock/unlock a session 
- Hides edit option if session is locked

If session is locked

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

uds5501

Looks good, push the corresponding server PR soon!

shreyanshdwivedi · 2019-05-20T16:53:15Z

@uds5501 @CosmicCoder96 @pradeepgangwar @kushthedude please review
Link to server side PR - fossasia/open-event-server#5931

kushthedude

Everything looks nice !

ritikamotwani · 2019-05-22T02:54:52Z

app/templates/components/ui-table/cell/events/view/sessions/cell-session-title.hbs

@@ -0,0 +1,14 @@
+{{record.title}}<br>


We generally avoid the use of the br tag. You can use a hidden divider instead.
Also there's no point of using a property name if you are using record.title simply to get the title.
May be you can use (get record column.propertyName) for it.

@ritikamotwani when I use <div class="hidden ui divider"></div> instead of <br> the separation becomes too large.
With hidden divider

With br tag

Should I implement this or not?

@shreyanshdwivedi , use the hidden divider one.

ritikamotwani · 2019-05-22T07:13:30Z

app/templates/components/ui-table/cell/events/view/sessions/cell-lock-session.hbs

@@ -0,0 +1,9 @@
+{{#if record.isLocked}}
+  {{#ui-popup content=(t 'Unlock Session') class='ui icon button'  click=(action unlockSession record) position='left center'}}


Make it a basic button like the other action buttons.

@ritikamotwani all the action buttons are also ui-popup as we need to show tooltip on hovering the buttons displaying the specific task which they carry out

Yes, I know what a popup is. I am talking about the class of the button used. Make it ui basic :)

fixes codacy issues updates buggy unlockSession condition and error message hide edit option for locked sessions fixes the class of lock icon and removes br tag

shreyanshdwivedi · 2019-05-22T14:27:19Z

@ritikamotwani I've updated the PR. Please review

uds5501 · 2019-05-22T20:52:44Z

app/controllers/events/view/sessions/list.js

@@ -72,6 +77,36 @@ export default Controller.extend({
    viewSession(id) {
      this.transitionToRoute('events.view.sessions.edit', id);
    },
+    lockSession(session) {
+      session.set('isLocked', true);
+      this.set('isLoading', true);


Everything looks good, but just had a question, wouldn't it be nice if the session.set('isLocked', true) be executed when isLoading is true? (I think it's just code design, won't affect the functionality, of course)

@uds5501 I did this intentionally. I had a number of references where values were set before setting isLoading to true. As we know that isLoading is basically for loading status if a task takes time so it is added just before the time-taking task. However, if you want you can refer to login-form or register-form where similar implementations were carried out.

Understood!

kushthedude

LGTM!

ritikamotwani · 2019-05-23T02:44:35Z

app/templates/components/ui-table/cell/events/view/sessions/cell-session-title.hbs

@@ -0,0 +1,15 @@
+{{record.title}}


Also there's no point of using a property name if you are using record.title simply to get the title.
May be you can use (get record column.propertyName) for it.

ritikamotwani · 2019-05-23T02:47:13Z

app/controllers/events/view/sessions/list.js

+          this.send('refreshRoute');
+        })
+        .catch(() => {
+          this.notify.error(this.get('l10n').t('An unexpected error has occurred.'));


Use this.notify....this.l10n

shreyanshdwivedi · 2019-05-23T03:35:51Z

@CosmicCoder96 @pradeepgangwar please review

fossasia deleted a comment May 19, 2019

shreyanshdwivedi mentioned this pull request May 19, 2019

feat: Implement locking a session feature by organizer fossasia/open-event-server#5931

Merged

6 tasks

shreyanshdwivedi force-pushed the sessionPage branch from ad01219 to dedc981 Compare May 19, 2019 23:48

fossasia deleted a comment May 19, 2019

uds5501 previously approved these changes May 20, 2019

View reviewed changes

shreyanshdwivedi dismissed uds5501’s stale review via b4ceed5 May 20, 2019 16:52

fossasia deleted a comment May 20, 2019

kushthedude previously approved these changes May 20, 2019

View reviewed changes

ritikamotwani suggested changes May 22, 2019

View reviewed changes

shreyanshdwivedi dismissed kushthedude’s stale review via e9b4320 May 22, 2019 13:48

shreyanshdwivedi force-pushed the sessionPage branch 2 times, most recently from e9b4320 to 92e41a6 Compare May 22, 2019 13:48

redesigns sessions page and add lock/unlock column

2fc76a2

fixes codacy issues updates buggy unlockSession condition and error message hide edit option for locked sessions fixes the class of lock icon and removes br tag

shreyanshdwivedi force-pushed the sessionPage branch from 92e41a6 to 2fc76a2 Compare May 22, 2019 14:11

fossasia deleted a comment May 22, 2019

shreyanshdwivedi changed the title ~~[WIP] feat: redesigns sessions page and add lock/unlock column~~ feat: redesigns sessions page and add lock/unlock column May 22, 2019

auto-label bot added the feature label May 22, 2019

uds5501 reviewed May 22, 2019

View reviewed changes

uds5501 previously approved these changes May 22, 2019

View reviewed changes

kushthedude previously approved these changes May 22, 2019

View reviewed changes

ritikamotwani suggested changes May 23, 2019

View reviewed changes

used column propertyName and ES6 getters

95ec7de

shreyanshdwivedi dismissed stale reviews from kushthedude and uds5501 via 95ec7de May 23, 2019 02:54

fossasia deleted a comment May 23, 2019

ritikamotwani approved these changes May 23, 2019

View reviewed changes

abhinavk96 approved these changes May 23, 2019

View reviewed changes

Merge branch 'development' into sessionPage

fa7efb9

abhinavk96 merged commit 21ecfc0 into fossasia:development May 23, 2019

shreyanshdwivedi deleted the sessionPage branch August 20, 2019 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: redesigns sessions page and add lock/unlock column #2964

feat: redesigns sessions page and add lock/unlock column #2964

shreyanshdwivedi commented May 19, 2019 •

edited

Loading

uds5501 left a comment

shreyanshdwivedi commented May 20, 2019

kushthedude left a comment

ritikamotwani May 22, 2019

shreyanshdwivedi May 22, 2019 •

edited

Loading

ritikamotwani May 22, 2019

ritikamotwani May 22, 2019

shreyanshdwivedi May 22, 2019

ritikamotwani May 22, 2019 •

edited

Loading

shreyanshdwivedi commented May 22, 2019

uds5501 May 22, 2019

shreyanshdwivedi May 22, 2019 •

edited

Loading

uds5501 May 22, 2019

kushthedude left a comment

ritikamotwani May 23, 2019

ritikamotwani May 23, 2019

shreyanshdwivedi commented May 23, 2019

		@@ -0,0 +1,9 @@
		{{#if record.isLocked}}
		{{#ui-popup content=(t 'Unlock Session') class='ui icon button' click=(action unlockSession record) position='left center'}}

feat: redesigns sessions page and add lock/unlock column #2964

feat: redesigns sessions page and add lock/unlock column #2964

Conversation

shreyanshdwivedi commented May 19, 2019 • edited Loading

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

uds5501 left a comment

Choose a reason for hiding this comment

shreyanshdwivedi commented May 20, 2019

kushthedude left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shreyanshdwivedi May 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ritikamotwani May 22, 2019 • edited Loading

Choose a reason for hiding this comment

shreyanshdwivedi commented May 22, 2019

Choose a reason for hiding this comment

shreyanshdwivedi May 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kushthedude left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shreyanshdwivedi commented May 23, 2019

shreyanshdwivedi commented May 19, 2019 •

edited

Loading

shreyanshdwivedi May 22, 2019 •

edited

Loading

ritikamotwani May 22, 2019 •

edited

Loading

shreyanshdwivedi May 22, 2019 •

edited

Loading