Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a pricing page with info #4919

Merged
merged 10 commits into from Sep 2, 2020
Merged

feat: Create a pricing page with info #4919

merged 10 commits into from Sep 2, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4741

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8bzu36o3x
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-8.eventyay.vercel.app

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-08-31 17-19-35
Screenshot from 2020-08-31 17-19-30

@mariobehling
Copy link
Member

This design is a bit far from the design of the rest of the frontend. Could you make something more similar to the rest of the site, please?

As we only have 1 tier for now maybe also look at other pricing page examples on the Internet, e.g. Hetzner https://www.hetzner.com/webhosting

Screenshot from 2020-08-31 21-36-51

@vercel vercel bot temporarily deployed to Preview September 1, 2020 09:34 Inactive
@vercel vercel bot temporarily deployed to Preview September 1, 2020 09:34 Inactive
@maze-runnar
Copy link
Contributor Author

maze-runnar commented Sep 1, 2020

@mariobehling I think this UI is similar to rest of website. Should I continue with this UI?

Screenshot from 2020-09-01 15-04-59

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #4919 into development will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4919      +/-   ##
===============================================
- Coverage        23.16%   22.86%   -0.30%     
===============================================
  Files              481      484       +3     
  Lines             5098     5129      +31     
  Branches            18       18              
===============================================
- Hits              1181     1173       -8     
- Misses            3913     3952      +39     
  Partials             4        4              
Impacted Files Coverage Δ
app/router.js 100.00% <ø> (ø)
app/components/widgets/forms/link-input.js 32.00% <0.00%> (-15.37%) ⬇️
app/utils/computed-helpers.js 21.95% <0.00%> (-8.05%) ⬇️
app/components/forms/wizard/basic-details-step.js 18.57% <0.00%> (-5.82%) ⬇️
app/mixins/event-wizard.js 1.13% <0.00%> (ø)
app/helpers/ui-grid-number.js 34.78% <0.00%> (ø)
app/controllers/public/session/view.js 0.00% <0.00%> (ø)
app/controllers/events/view/edit/other-details.js 0.00% <0.00%> (ø)
app/components/forms/wizard/other-details-step.js 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9663982...a86d18e. Read the comment docs.

@maze-runnar maze-runnar changed the title WIP: Create a pricing page with info feat: Create a pricing page with info Sep 1, 2020
@auto-label auto-label bot added the feature label Sep 1, 2020
@iamareebjamal
Copy link
Member

  • Please make it a single table (Features, Availability)
  • Add actual data in it
  • Still different from website design. Look at how cards are present in Event Dashboard

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-09-01 22-02-39
Screenshot from 2020-09-01 22-02-36

@maze-runnar
Copy link
Contributor Author

@iamareebjamal please review.
Screenshot from 2020-09-01 22-02-32

@iamareebjamal
Copy link
Member

Looks good to me. Please remove double border

@mariobehling
Copy link
Member

Thanks. Looks good to me.

Please use a full page screenshot tool to make it easier for everyone when viewing examples.

Check out for example https://chrome.google.com/webstore/search/screenshot

@maze-runnar
Copy link
Contributor Author

scrnli_9_2_2020_12-49-43 PM

@iamareebjamal
Copy link
Member

Please use a container like done previously so the content doesn't span the entire page width

@maze-runnar
Copy link
Contributor Author

Please use a container like done previously so the content doesn't span the entire page width

it will add border like before after using grid.

@iamareebjamal
Copy link
Member

Add a class which removes the border. Besides, there must be a class in semantic UI which just contains the items. Try ui.container

@maze-runnar
Copy link
Contributor Author

scrnli_9_2_2020_1-31-46 PM

@iamareebjamal iamareebjamal merged commit 8cc8765 into fossasia:development Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pricing Page: Create a pricing page with info in the central column
3 participants