fix: Partially enhance event dashboard #5139

Raunaksingh100 · 2020-09-24T18:02:10Z

Short description of what this resolves:

in this pr i fixed the points given below--

Delete row "number of revisions".
Change "External Event URL" to "Event Site".

Fixes #5131

screenshot before-

screenshot after-

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
@iamareebjamal plz review now I fixed 3 points

vercel · 2020-09-24T18:02:19Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dffzbk86t
✅ Preview: https://open-event-frontend-git-dev5.eventyay.vercel.app

iamareebjamal · 2020-09-24T18:11:24Z

app/styles/pages/public-event.scss

@@ -185,3 +185,7 @@
 .event-map > iframe.g-map {
  height: 300px;
 }
+
+.content a {
+  text-transform: capitalize;


This will capitalize all links in any content container on any page, and not just social media links on event detail page as listed in the issue

@iamareebjamal i will fixed this

mariobehling · 2020-09-24T18:21:08Z

This change also has some other breaking changes, e.g. the page now shows the unpublished scheduled while on the live site it does not show the schedule yet.

codecov · 2020-09-24T18:48:14Z

Codecov Report

Merging #5139 into development will increase coverage by 0.59%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5139      +/-   ##
===============================================
+ Coverage        22.65%   23.24%   +0.59%     
===============================================
  Files              489      493       +4     
  Lines             5191     5170      -21     
  Branches            36       38       +2     
===============================================
+ Hits              1176     1202      +26     
+ Misses            4010     3963      -47     
  Partials             5        5

Impacted Files	Coverage Δ
app/models/social-link.js	`0.00% <ø> (ø)`
app/components/forms/orders/guest-order-form.js	`14.28% <0.00%> (-5.72%)`	⬇️
app/models/event.js	`50.00% <0.00%> (-3.85%)`	⬇️
app/controllers/register.js	`34.28% <0.00%> (-2.08%)`	⬇️
app/mixins/ember-table-route.js	`75.00% <0.00%> (-1.93%)`	⬇️
app/components/events/view/publish-bar.ts	`15.62% <0.00%> (-1.62%)`	⬇️
app/components/public/ticket-list.js	`18.96% <0.00%> (-1.22%)`	⬇️
app/mixins/event-wizard.js	`0.89% <0.00%> (-0.05%)`	⬇️
app/router.js	`100.00% <0.00%> (ø)`
app/routes/pages.js	`0.00% <0.00%> (ø)`
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa674a9...7e9a9e4. Read the comment docs.

Raunaksingh100 · 2020-09-27T14:57:44Z

@iamareebjamal @mariobehling plz review i fixed this bug with id

lgtm-com · 2020-10-05T10:26:17Z

This pull request introduces 1 alert when merging 9b98ab7 into e044006 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

niranjan94 · 2020-10-05T10:37:55Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

See the complete overview on Codacy

niranjan94 · 2020-10-05T10:37:58Z

app/models/social-link.js


 export default ModelBase.extend({
  name       : attr('string'),
  link       : attr('string'),
  identifier : attr('string'), // used for providing css id for URL validations.

  event: belongsTo('event'),
-
+  


Codacy found an issue: Trailing spaces not allowed.

Please don't resolve the conversations. They are resolved automatically

niranjan94 · 2020-10-05T10:37:59Z

app/models/social-link.js

@@ -4,14 +4,15 @@ import attr from 'ember-data/attr';
 import ModelBase from 'open-event-frontend/models/base';
 import { belongsTo } from 'ember-data/relationships';
 import { computedSegmentedLink, socialPlatforms } from 'open-event-frontend/utils/computed-helpers';
+import { capitalize } from 'lodash-es';


Codacy found an issue: 'capitalize' is defined but never used.

lgtm-com · 2020-10-05T10:40:55Z

This pull request introduces 1 alert when merging 1470cd9 into e044006 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

iamareebjamal · 2020-11-03T14:11:54Z

app/models/social-link.js

@@ -31,4 +31,4 @@ export default ModelBase.extend({
  }),

  segmentedLink: computedSegmentedLink.bind(this)('link')
-});
+});


Suggested change

});

});

iamareebjamal · 2020-11-03T15:28:41Z

app/models/social-link.js

@@ -11,7 +11,6 @@ export default ModelBase.extend({
  identifier : attr('string'), // used for providing css id for URL validations.

  event: belongsTo('event'),
-


Why did you delete the line

@iamareebjamal according to this

There is a difference between a space and a line

@iamareebjamal now no error

Co-authored-by: Mario Behling <mb@mariobehling.de>

fix: capital the link name and change url name

42cc15e

vercel bot deployed to Preview September 24, 2020 18:02 View deployment

auto-label bot added the fix label Sep 24, 2020

iamareebjamal reviewed Sep 24, 2020

View reviewed changes

vercel bot deployed to Preview September 24, 2020 18:31 View deployment

Raunaksingh100 closed this Sep 24, 2020

iamareebjamal reopened this Sep 24, 2020

Raunaksingh100 closed this Sep 24, 2020

iamareebjamal reopened this Sep 24, 2020

iamareebjamal mentioned this pull request Sep 24, 2020

fix: Event Dashboard #5141

Closed

5 tasks

Raunaksingh100 force-pushed the dev5 branch from 6c9340c to 4653995 Compare September 24, 2020 18:58

vercel bot temporarily deployed to Preview September 24, 2020 18:58 Inactive

vercel bot temporarily deployed to Preview September 24, 2020 19:02 Inactive

vercel bot deployed to Preview September 24, 2020 19:03 View deployment

Raunaksingh100 added 2 commits September 25, 2020 00:34

Fix:Remove row of number of revesions and remove previous change

1f00aca

Fix:Remove row of number of revesions and remove previous change

5abdd53

Raunaksingh100 force-pushed the dev5 branch from 4935c79 to 5abdd53 Compare September 24, 2020 19:05

vercel bot deployed to Preview September 24, 2020 19:05 View deployment

cggvuhh previously approved these changes Sep 25, 2020

View reviewed changes

Fix:Remove row of number of revesions and Capatilaze the Scoial name

35e4436

Raunaksingh100 dismissed cggvuhh’s stale review via 35e4436 September 25, 2020 08:02

vercel bot deployed to Preview September 25, 2020 08:03 View deployment

cggvuhh previously approved these changes Sep 25, 2020

View reviewed changes

Fix:Remove row of number of revesions and Capatilaze the Scoial name

2b75aa4

Raunaksingh100 dismissed cggvuhh’s stale review via 2b75aa4 September 27, 2020 14:56

vercel bot deployed to Preview September 27, 2020 14:56 View deployment

vercel bot deployed to Preview October 5, 2020 10:35 View deployment

niranjan94 reviewed Oct 5, 2020

View reviewed changes

vercel bot deployed to Preview November 3, 2020 14:05 View deployment

Raunaksingh100 requested review from mariobehling and iamareebjamal November 3, 2020 14:09

cggvuhh previously approved these changes Nov 3, 2020

View reviewed changes

iamareebjamal reviewed Nov 3, 2020

View reviewed changes

Raunaksingh100 dismissed cggvuhh’s stale review via 0f86009 November 3, 2020 14:14

vercel bot deployed to Preview November 3, 2020 14:14 View deployment

vercel bot deployed to Preview November 3, 2020 14:27 View deployment

vercel bot deployed to Preview November 3, 2020 14:31 View deployment

vercel bot deployed to Preview November 3, 2020 14:37 View deployment

vercel bot deployed to Preview November 3, 2020 14:46 View deployment

vercel bot deployed to Preview November 3, 2020 14:53 View deployment

fix remove the revesion row and change external event url name

30a3fc0

Raunaksingh100 force-pushed the dev5 branch from 790d120 to 30a3fc0 Compare November 3, 2020 15:01

vercel bot deployed to Preview November 3, 2020 15:01 View deployment

iamareebjamal reviewed Nov 3, 2020

View reviewed changes

fix remove the revesion row and change external event url name

7e9a9e4

vercel bot deployed to Preview November 3, 2020 15:52 View deployment

Raunaksingh100 requested a review from iamareebjamal November 3, 2020 15:53

iamareebjamal changed the title ~~fix: Event Dashboard~~ fix: Partially enhance event dashboard Nov 3, 2020

iamareebjamal approved these changes Nov 3, 2020

View reviewed changes

iamareebjamal merged commit d523841 into fossasia:development Nov 3, 2020

akash2408 pushed a commit to akash2408/open-event-frontend that referenced this pull request Nov 4, 2020

fix: Partially enhance event dashboard (fossasia#5139)

88f05b1

Co-authored-by: Mario Behling <mb@mariobehling.de>

Raunaksingh100 deleted the dev5 branch November 12, 2020 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Partially enhance event dashboard #5139

fix: Partially enhance event dashboard #5139

Raunaksingh100 commented Sep 24, 2020 •

edited

Loading

vercel bot commented Sep 24, 2020 •

edited

Loading

iamareebjamal Sep 24, 2020

Raunaksingh100 Sep 24, 2020

mariobehling commented Sep 24, 2020

codecov bot commented Sep 24, 2020 •

edited

Loading

Raunaksingh100 commented Sep 27, 2020

lgtm-com bot commented Oct 5, 2020

niranjan94 commented Oct 5, 2020

niranjan94 Oct 5, 2020

iamareebjamal Nov 3, 2020

niranjan94 Oct 5, 2020

lgtm-com bot commented Oct 5, 2020

iamareebjamal Nov 3, 2020

iamareebjamal Nov 3, 2020

Raunaksingh100 Nov 3, 2020

iamareebjamal Nov 3, 2020

Raunaksingh100 Nov 3, 2020

		@@ -11,7 +11,6 @@ export default ModelBase.extend({
		identifier : attr('string'), // used for providing css id for URL validations.

		event: belongsTo('event'),

fix: Partially enhance event dashboard #5139

fix: Partially enhance event dashboard #5139

Conversation

Raunaksingh100 commented Sep 24, 2020 • edited Loading

Short description of what this resolves:

screenshot before-

screenshot after-

Checklist

vercel bot commented Sep 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mariobehling commented Sep 24, 2020

codecov bot commented Sep 24, 2020 • edited Loading

Codecov Report

Raunaksingh100 commented Sep 27, 2020

lgtm-com bot commented Oct 5, 2020

niranjan94 commented Oct 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Oct 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Raunaksingh100 commented Sep 24, 2020 •

edited

Loading

vercel bot commented Sep 24, 2020 •

edited

Loading

codecov bot commented Sep 24, 2020 •

edited

Loading